fix when using multiple versions of html-webpack-plugin

jharris4 / html-webpack-tags-plugin

lets you define html tags to inject with html-webpack-plugin

MIT License

256 stars 31 forks source link

fix when using multiple versions of html-webpack-plugin #70

Closed ndunks closed 3 years ago

ndunks commented 3 years ago

I have experienced issue when use with vue-cli because of multiple versions 'html-webpack-plugin'. Issue fixed by checking with its constructor name instead of class instance.

jharris4 commented 3 years ago

Hi, thanks for the PR! I'll see if I can get this merged soon...

Can you provide some detail on how to reproduce the issue? Also what multiple versions of html-webpack-plugin ?

ndunks commented 3 years ago

After deep checking, the problem is not on the plugin, but in @vue/cli-service@~4.5.0 that depends on html-webpack-plugin "^3.2.0". even I fix the error build process (by installing html-webpack-plugin@^5.0.0 as direct dependency), but the tags is not inserted because different instance of html-webpack-plugin. Thanks for your attention.