search

jhass / insporation

Flutter based client for diaspora*
BSD 3-Clause "New" or "Revised" License
30 stars 3 forks source link

Simplified error messages on sign in. #22

Closed tclaus closed 3 years ago

tclaus commented 3 years ago

Changed technical messages to generic message. In iOS case it could be possible, that Main view occured, but with a error

Changed from

Bildschirmfoto 2020-11-06 um 18 27 40

To:

Bildschirmfoto 2020-11-06 um 19 33 57
jhass commented 3 years ago

I feel this too simplistic and often outright wrong. There's many more error cases in here than "could not resolve host". You also simply dropped the logic recovering from an expired or removed authorization for example. Also what is an "Invalid API", I don't think that's a good name :)

tclaus commented 3 years ago

It turns out, that on iOS side the exceptions thrown in case of an error don't follow the exception codes in the DART / KT file. I'll fix this

tclaus commented 3 years ago

(Code suggestions arte nice, but leads to too many extra commits, will collect them in one commit next time)

jhass commented 3 years ago

You can batch commit them from the files tab.