jhass / insporation

Flutter based client for diaspora*
BSD 3-Clause "New" or "Revised" License
30 stars 3 forks source link

Render a fallback widget with debug info when rendering some message content fails #35

Closed jhass closed 4 years ago

jhass commented 4 years ago

Prevents crashes for cases like #37

tclaus commented 4 years ago

How to produce a error case, to see changes here?

jhass commented 4 years ago

Make a new post with

<http://example.org

http://example.com>

Note that I didn't spend much time to make this pretty here. It's something that should never happen and is just a fallback to prevent crashing the app and give us just enough info to debug the issue.

tclaus commented 4 years ago

Make a new post with

<http://example.org

http://example.com>

Is the line break the important part? If I create a post like this - it look on webUI the same as in the App. WYSIWYG: The first one is build with well formatted markdown, the second was build like in your text. If this is w IMG_6A0310E36BB7-1

With this PR I see no difference in the App.

jhass commented 4 years ago

Yes, all the line breaks are important, remove any and it doesn't crash anymore.

jhass commented 4 years ago

Ah well, I'd love to stick to color scheme and not add random colors here and there. Remember this is another "should never happen and if it happens it's a real bug" case.