search

jhass / insporation

Flutter based client for diaspora*
BSD 3-Clause "New" or "Revised" License
30 stars 3 forks source link

Properly handle failing discovery on unsupported servers #6

Closed norayr closed 2 years ago

norayr commented 4 years ago

sorry if opening an issue is not a right way to deal with this. you can close it then.

so, i have tried it wtih two jids - one at spyurk.am, other at joindiaspora.com. after entering jid on the first screen, i see the continuously loading screen, forever.

os: lineageos-17.1, it is android 10

jhass commented 4 years ago

https://version.diaspora.social/spyurk.am

The pod runs on 0.7.14.0.

https://version.diaspora.social/joindiaspora.com

The pod runs on 0.7.14.0.

README.md:

This is still in preview. You will need a pod on the latest develop branch.

I guess the error handling around this could be better though :)

norayr commented 4 years ago

oh probably the dev branch contains client api? then close the thread. (:

jhass commented 4 years ago

oh probably the dev branch contains client api?

Yeah exactly. Let me dig into why it gets stuck though, will be useful for the transition phase after the release to get this right :)

jhass commented 4 years ago

Required upstream fix to properly handle this: https://github.com/openid/AppAuth-Android/pull/611

tclaus commented 4 years ago

Looks much better with #22 Timeout was originally set tp 60sec with seems to be almost infinite. You'll get a error message either a nice 'timeout' or a hint that pod does not run a v0.8 pod. (Which is currently in beta stage) @jhass request to close this issue?

jhass commented 4 years ago

No, I want to change the message and more properly detect this case (well, that's likely covered by #22 then) once upstream is fixed to allow to do so.

jhass commented 4 years ago

Timeout was originally set to 60sec

Quite OT here, but I can tell you from four years of professional app development that a connection latency of 30 seconds or more is not unseen on mobile networks, especially as the user is roaming between cells (= walking or driving around).

tclaus commented 2 years ago

spyurk.am (now) runs on 7.99 dev branch and should support this App. As v1.0.0 looms on the horizon it is unlikely that unsupported pods will be supported in insporation.