jhass / nextcloud-keeweb

Integrate Keeweb into Nextcloud
Other
415 stars 48 forks source link

Where to set client id and secret for OneDrive (and other cloud providers)? #190

Open atkulp opened 2 years ago

atkulp commented 2 years ago

Looking through the repo, I see a reference to them in the nextcloud-keeweb/default_settings.patch folder, but no place to actually configure them. Am I missing it? It's using a client ID starting with bbc74d1b at the moment which then gives an error on redirect_uri. Not sure if I got that in there somehow or what, but I can't see where to set it now.

Thanks!

arnowelzel commented 2 years ago

Well - this is the Keeweb integration for Nextcloud. I don't see the point in providing a client ID and secret for OneDrive and other providers. The app only needs to work with Nextcloud. What is the use case?

atkulp commented 2 years ago

The Keeweb app has Open buttons for OneDrive and other cloud providers. Since I'm using OneDrive for that file already, I don't want a second copy within Nextcloud. I can see why it's odd, but doesn't the core Keeweb code already support it?

arnowelzel commented 2 years ago

Yes, the Keeweb core supports opening files from other locations as well. Nevertheless Keeweb for Nextcloud only provides WebDAV and local files:

image

Also keep in mind that using OneDrive is not that simple, also see https://github.com/keeweb/keeweb/issues/683