jhass / nextcloud-keeweb

Integrate Keeweb into Nextcloud
Other
416 stars 49 forks source link

Keyfile selection from Files/Webdav #7

Open ghost opened 8 years ago

ghost commented 8 years ago

Please, add some kind of possibility to select database's key file from webdav

jhass commented 8 years ago

Keyfile integration is hard. While there's a property for the key file path on the model (https://github.com/keeweb/keeweb/blob/develop/app/scripts/models/file-info-model.js#L16) , it's not being passed from the config we can provide (https://github.com/keeweb/keeweb/blob/develop/app/scripts/models/app-model.js#L79-L85). I'm also not sure what UX story we can expect here, there doesn't seem to be any popup file chooser we can reuse in Nextcloud, nor a Webdav file browser in Keeweb, and implementing either is a bit out of scope of this app.

In reply to https://help.nextcloud.com/t/keeweb-integration/2209/8

For keyfile, maybe you can add a search box, no need for popup file chooser, in search box we can enter the path and the first letters

A search box sounds easier from the user perspective, but actually isn't any less involved from the backend code, it merely makes the UI part a little bit easier.

The other issue making this hard is that there's no really sane way to hook into Keeweb's UI.

@antelle sorry for calling you in on this, but if you think I'm missing something or have any other thoughts or ideas on it, I'd love to hear about them.

antelle commented 8 years ago

There's an issue in keeweb for keyfile selection: https://github.com/keeweb/keeweb/issues/183 (there are several concerns mentioned in the issue comments but generally it's a good idea, to allow selection from storage). Once it gets implemented, we could also add a config property for keyfile.

gymnae commented 8 years ago
CrysK commented 5 years ago

Is it possible now? I didn't find some option.

It would be even greater to load a key file from ftp/sftp/ftps.