search

jhassan8 / crunchyroll-tizen

Crunchyroll unofficial app for Smart TV Samsung Tizen OS that currently doesnt exist in appstore, requires crunchyrrol account.
Apache License 2.0
174 stars 17 forks source link

Scrolling out of view on Home-Screen #67

Open felixkmh opened 1 year ago

felixkmh commented 1 year ago

Describe the bug When on the Home-Screen, scrolling down seems to add the wrong offset, such that the selected row keeps moving down with every step. Also the distance between the rows seems off. I can not see the second row when the first one is selected and there is just empty space below it.

To Reproduce Steps to reproduce the behavior:

  1. Go to Home-Screen
  2. Navigate down

Expected behavior Selected row stays visible and does not shift downwards with every step.

Screenshots Here's a clip of me just navigating all the way down, and then up again:

https://github.com/jhassan8/crunchyroll-tizen/assets/24227002/1562a974-cc7c-46fe-a23d-7aac36b1335d

Additional context App-Version: 1.1.3b TV: GQ55S90CATXZG (4K), Version 1310.3

jhassan8 commented 1 year ago

hi @felixkmh, before to version 1.1.3b did this work correctly? I am trying to solve a similar error that happens only on some TVs.

felixkmh commented 1 year ago

Hi, I checked with version 1.1.1, and the issue is also present. But in addition, it seems like the selection box is also twice as high as it should be.

felixkmh commented 1 year ago

It's also possible that the problem also occurs on other devices, just less noticable. I tried running it in an emulator at 1080p and the selected row still shifts downwards when scrolling down, but only a few pixels at a time. So it's not as noticable.

felixkmh commented 1 year ago

There seems to be an issue with slick and vertical mode too, when slides have varying heights: https://github.com/kenwheeler/slick/issues/2962 https://github.com/kenwheeler/slick/issues/1803 And in my case, the first row seems to have a different height, compared to the others.

jhassan8 commented 10 months ago

hi @felixkmh, please test the new my list screen (v1.1.5) with more than one crunchylist, to check if the solution implemented there works, so I replicate it on the other screens...

if you have the ..._online.wgt version installed, it is not necessary to reinstall the app, just turn off the TV and turn it on again to clean the app cache and load the new one version.

if you have the ..._offline_vX.X.X.wgt version installed, you must install the new version.

thanks

felixkmh commented 10 months ago

Hi @jhassan8, I tried using the new list screen with multiple lists and as far as I can tell there is no issue with the lists shifting when scrolling. But the issue on the home screen seemed to be present when rows had different heights. The rows in the My lists view all seem to have the same height.