search

jhasse / poly2tri

2D constrained Delaunay triangulation library
BSD 3-Clause "New" or "Revised" License
429 stars 89 forks source link

Stability fixes #43

Closed AndriyAndreyev closed 2 years ago

AndriyAndreyev commented 2 years ago
  1. Added fix that LargeHole_DontFill is true if an angle is negative. Fixes stack overflow crash #41.
  2. Added test for LargeHole_DontFill changes.
jhasse commented 2 years ago

Can you add a unit test with the test case?

AndriyAndreyev commented 2 years ago

Can you add a unit test with the test case?

I added a test geometry - https://github.com/jhasse/poly2tri/pull/43/commits/8b3adb863c5a06f3e730bd9095472cc349511e73 I'll try to add a unit test too.

AndriyAndreyev commented 2 years ago

Can you add a unit test with the test case?

Unittest is added in a testbed-data-file way. But I have problems with the building environment and cannot run these tests. Can you please check if it works fine if you have a ready build environment?

AndriyAndreyev commented 2 years ago

Added a unit test for checking crashes in a common way