Closed jhauserw3241 closed 7 years ago
I really suggest you update the config.ini with the desired app_name and app_tagline
I saw that, but do you think it would be better to update it there or just remove it from the config? Theoretically, once I change it in the base.html file, it will never change again, right?
If we ever want to print the app name or app tagline somewhere else, variables are great. If this spot in the header is the only place you expect them to be, then removing all app_name and app_tagline and opting for hard-coded values is fine.
Ok. I'm fine with that. However, I was thinking about putting the logo instead of the tagline. Should I put the location to the file there instead?
If we are putting a logo and "Cyber Defense Club" up there, we're going to be restructuring anyway. Might as well remove the app_* variables.
Where are those defined?
In config.ini and used at the bottom of server.py
Additionally, I don't think I can modify the config.ini file the way that my current git ignore file is setup. Do you want to do that or should I?
If you think it would be helpful to keep the app_* variables, I'm fine with that. I'm just wondering what the best way to go about using them is.
Because we could remove the tagline variable and create a logo variable and they would work great.
config.ini is not version controlled for security reasons. It has secrets in it.
Add/remove whatever variables you want in it. Use them wherever you want. If a variable isn't used anywhere, it should get removed from config.ini
Whatever you do and commit to master I will do on the "authoritative" copy of the website at https://cdcdb.system33.pw
If you're going to configure a logo path in config.ini, it should probably look something like '/static/logo.png'. Ya know, the path part of the URL so you can <img src='{{ app_logo }}'>
Ok, but then how do you want me to get my changes to the config file to you?
I can just snoop on your home folder
edit: getting the config.ini to me is the easiest part. Don't worry about it :)
That works. Ok. Sounds good. Working on that now.
https://github.com/pastly/cdcdb-webserver/blob/master/server.py#L282
I think all that needs to happen is updating config.ini
edit: maybe there's other references to "cdcdb," but a quick grep would help find hard-coded "cdcdb" strings.
grep -rni cdcdb /path/to/src/cdcdb