search

jhavl / swift

MIT License
86 stars 22 forks source link

Remove leading slash for paths to be retrieved #52

Open KuabeM opened 11 months ago

KuabeM commented 11 months ago

The leading slash breaks windows compatibility as paths starting with /C:/ can't be resolved on windows, as mentioned here https://github.com/jhavl/swift/commit/f6c8cdea481b713540b5889c0c8c125ca0cc3ac0#r116060265. Removing this leading slash on Linux does not change the behavior, paths like /home/... and //home/... can both be resolved.

Here's the output of the commented print call for self.path[10:] on Linux:

Retrieving file: /home/<redacted>/meshes/link_base_1.STL

And here's the output of the commented print call for self.path[9:]:

Retrieving file: //home/<redacted>/meshes/link_base_1.STL

Is there any reason to keep this for *nix platforms? If yes I'd be happy to add a conditional parsing.

kappa95 commented 11 months ago

This solved my issue (ISSUE #50)

Muhammadsgit commented 9 months ago

Solved my issue as well. Thanks!

kongyuanchao commented 7 months ago

My issue has been solved. Big thanks!

apojomovsky commented 6 months ago

Thanks @KuabeM , this seem to have solved the issue we were all facing when attempting to load meshes when running a simulation.

@jhavl is there anything that we could do to help getting these changes merged?