jhawthorn / pub_grub

🍔 A ruby implementation of the PubGrub CDCL-based version solver
MIT License
151 stars 11 forks source link

Example crashes with uninitialized constant PubGrub::RubyGems (NameError) #28

Open mensfeld opened 1 year ago

mensfeld commented 1 year ago
source = PubGrub::StaticPackageSource.new do |s|
  s.add 'foo', '2.0.0', deps: { 'bar' => '1.0.0' }
  s.add 'foo', '1.0.0'

  s.add 'bar', '1.0.0', deps: { 'foo' => '1.0.0' }

  s.root deps: { 'foo' => '>= 1.0.0' }
end

solver = PubGrub::VersionSolver.new(source: source)
solver.solve # => {#<PubGrub::Package :root>=>0, "foo"=>#<Gem::Version "1.0.0">}

crashes with:

pub_grub-0.5.0/lib/pub_grub/static_package_source.rb:50:in `parse_dependency': uninitialized constant PubGrub::RubyGems (NameError)
mensfeld commented 1 year ago

pub_grub/rubygems ain't loaded by default.

deivid-rodriguez commented 1 year ago

It sounds like an easy fix, care to send a PR?

mensfeld commented 1 year ago

@deivid-rodriguez if you give me like a week or two ;)