search

jhawthorn / pub_grub

🍔 A ruby implementation of the PubGrub CDCL-based version solver
MIT License
151 stars 11 forks source link

Detect infinite loops when resolving conflicts #29

Closed deivid-rodriguez closed 1 year ago

deivid-rodriguez commented 1 year ago

We've been getting several reports about Bundler hanging infinitely when resolving.

I believe this is a bug in pub_grub, but while I isolate a test case and fix, I think it's an improvement already to detect infinite loops when resolving conflicts and bail out.

We can remove this once the culprit is properly addressed.

deivid-rodriguez commented 1 year ago

I think, even if this does not fix the root cause, it's a strict improvement over what we have so I'm merging it!