Closed hsbt closed 10 months ago
👋 Hi, Thank you for maintaining pub_grub.
pub_grub
I got NameError with sample code like:
NameError
$ cat -p sample1.rb require "pub_grub" source = PubGrub::StaticPackageSource.new do |s| s.add 'foo', '2.0.0', deps: { 'bar' => '1.0.0' } s.add 'foo', '1.0.0' s.add 'bar', '1.0.0', deps: { 'foo' => '1.0.0' } s.root deps: { 'foo' => '>= 1.0.0' } end solver = PubGrub::VersionSolver.new(source: source) result = solver.solve $ ruby sample1.rb /Users/hsbt/.local/share/gem/gems/pub_grub-0.5.0/lib/pub_grub/static_package_source.rb:50:in `parse_dependency': uninitialized constant PubGrub::RubyGems (NameError) PubGrub::RubyGems.parse_constraint(package, dependency) ^^^^^^^^^^
I'm not sure why pub_grub/rubygems.rb is not required by lib/pub_grub/static_package_source.rb. But PubGrub::StaticPackageSource always refer PubGrub::RubyGems. We should load it explicitly.
pub_grub/rubygems.rb
lib/pub_grub/static_package_source.rb
PubGrub::StaticPackageSource
PubGrub::RubyGems
Thanks!
👋 Hi, Thank you for maintaining
pub_grub
.I got
NameError
with sample code like:I'm not sure why
pub_grub/rubygems.rb
is not required bylib/pub_grub/static_package_source.rb
. ButPubGrub::StaticPackageSource
always referPubGrub::RubyGems
. We should load it explicitly.