jhawthorn / vernier

📏 next generation CRuby profiler
https://vernier.prof/
MIT License
718 stars 15 forks source link

Remove unused var and redundant raise in `Vernier::Output::Firefox` #32

Closed joshuay03 closed 8 months ago

joshuay03 commented 8 months ago

I ran into this failure when trying this tool out using Ruby 3.2.2.


/Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/warning-1.3.0/lib/warning.rb:260:in `warn': /Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/vernier-0.3.0/lib/vernier/output/firefox.rb:240: warning: assigned but unused variable - size (RuntimeError)
        from /Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/vernier-0.3.0/lib/vernier.rb:7:in `require_relative'
        from /Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/vernier-0.3.0/lib/vernier.rb:7:in `<top (required)>'
        from <internal:/Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
        from <internal:/Users/[redacted]/.rbenv/versions/3.2.2/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
        ...
rake aborted!
Command failed with status (1)
/Users/[redacted]/.rbenv/versions/3.2.2/bin/bundle:25:in `load'
/Users/[redacted]/.rbenv/versions/3.2.2/bin/bundle:25:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)

This PR removes the unused var and also removes a redundant raise I noticed.

jhawthorn commented 8 months ago

Thanks!