search

jhawthorn / vernier

📏 next generation CRuby profiler
https://vernier.prof/
MIT License
718 stars 15 forks source link

We should gzip by default #47

Closed jhawthorn closed 2 months ago

jhawthorn commented 7 months ago

The viewer supports it, so let's do it always

dalehamel commented 4 months ago

I have seen some vernier profiles that are 100MB+ (lots of threads I guess?), gzipped they are about 15Mb, so there is definitely a case for this.

mikebaldry commented 2 months ago

How do you want to handle this? I've implemented it in a simple way (compress is an option and it defaults to true) but not sure that is ideal. You'll end up with .json files that are actually .json.gz contents.. I was thinking maybe do it automatically, only if the filename ends with .gz, or you explicitly pass compress: true - What do you think?

jhawthorn commented 2 months ago

@mikebaldry Sorry! I missed your comment. I implemented this in https://github.com/jhawthorn/vernier/commit/1cee8309eb1f9130a4d0942363b3f770d4232350