search

jhawthorn / vernier

📏 next generation CRuby profiler
https://vernier.prof/
MIT License
718 stars 15 forks source link

Update README to emphasize Ruby version requirement #50

Closed davidteren closed 6 months ago

davidteren commented 6 months ago

This change adds the minimum Ruby version requirement so that users do not spend time wondering why the Vernier traces are malformed and fail to render in the profile viewers ☺️

jhawthorn commented 6 months ago

so that users do not spend time wondering why the Vernier traces are malformed and fail to render in the profile viewers

How did you install vernier without the minimum Ruby version? 😅 We should be enforcing it via gemspec https://github.com/jhawthorn/vernier/blob/main/vernier.gemspec#L15

casperisfine commented 6 months ago

I suspect they got an older version? e.g. https://rubygems.org/gems/vernier/versions/0.1.0

jhawthorn commented 6 months ago

Ah! 😓 that makes sense. Maybe I should cut a 1.0 as well and specify ~> 1.0 in the install to avoid that.