jhawthorn / vernier

📏 next generation CRuby profiler
https://vernier.prof/
MIT License
718 stars 15 forks source link

Add `Vernier#start_profile` and `Vernier#stop_profile` #59

Closed joshuay03 closed 3 months ago

joshuay03 commented 3 months ago

Closes https://github.com/jhawthorn/vernier/issues/58

joshuay03 commented 3 months ago

@jhawthorn Thanks for having a look. I've addressed your first comment, I'll get a follow up PR up for the other 2 sometime this week. The test failure seems unrelated.

jhawthorn commented 3 months ago

Yeah, I've seen that failure a couple times. We probably need to either test with a range for allocations or filter out Ruby internal allocations like IMEMO which are going to be unreliable.