search

jhawthorn / vernier

📏 next generation CRuby profiler
https://vernier.prof/
MIT License
718 stars 15 forks source link

Set pre-selected (main) thread to be the profile start thread #75

Closed joshuay03 closed 1 week ago

joshuay03 commented 4 weeks ago

Closes https://github.com/jhawthorn/vernier/issues/56

Got a PR up for this one and #76 cause my C++ is rough.

I tested this out manually as well.

jhawthorn commented 2 weeks ago

I think is_main should probably always be the main thread. What I had in mind (sorry for the poor description 😅) is that we would set initialSelectedThreads https://github.com/firefox-devtools/profiler/blob/main/src/types/profile.js#L913-L916 which I think will change what firefox selects/shows by default (though I haven't tried it so 🤞).

Do you think that makes sense to do? I was hoping that would make single-request-in-puma or single-job-in-puma type profiles more intuitive without extra work at the start to select them.

joshuay03 commented 1 week ago

Ah I misunderstood, but yes that makes sense to me, and will be a good UX change. I'll action 👍🏽

joshuay03 commented 1 week ago

Closing in favour of https://github.com/jhawthorn/vernier/pull/78