search

jhc-systems / sqlest

Write SQL in Scala
https://jhc-systems.github.io/sqlest/latest/api/
Apache License 2.0
30 stars 17 forks source link

Added support for ByteArrayColumnType, fixes #23 #28

Closed kutchar closed 9 years ago

kutchar commented 9 years ago

So here's my first stab at adding support for binary columns. Please review and comment.

I tried to cover all the parts, including the DB2StatementBuilder, which I set the type to binary(32704) because of this.

As for string representation of byte[], I use JVMs javax.xml.bind.DatatypeConverter to encode/decore to Hex strings.

brendanator commented 9 years ago

Thanks for this pull request and the other issues you've raised. This looks really good

Before I can merge this would you be able to sign our contributor license agreement please https://github.com/jhc-systems/sqlest/blob/master/CONTRIBUTING.txt

kutchar commented 9 years ago

Thanks @brendanator. I just emailed the signed CLA to ian.haines@jhc.co.uk. BTW, what's the release cycle of sqlest? When can you release a minor version with these fixes?

brendanator commented 9 years ago

@kutchar - I've merged this and added some tests. Thanks!!

I'll look into the 22 columns issue first and then will create a new release

kutchar commented 9 years ago

Cool, thanks!

brendanator commented 9 years ago

@kutchar - I've create release 0.6.1, with your pull requests. The select * example will have to wait as I've been too busy this week and am on holiday next

ghost commented 9 years ago

Thanks! Enjoy your holiday.