search

jhc-systems / sqlest

Write SQL in Scala
https://jhc-systems.github.io/sqlest/latest/api/
Apache License 2.0
30 stars 17 forks source link

Return generated keys from resultset #68

Closed p14n closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 79.96%

Merging #68 into master will decrease coverage by -0.52% as of c0e95b9

@@            master     #68   diff @@
======================================
  Files           41      42     +1
  Stmts         1107    1138    +31
  Branches       118     125     +7
  Methods                          
======================================
+ Hit            891     910    +19
  Partial          0       0       
- Missed         216     228    +12

Review entire Coverage Diff as of c0e95b9

Uncovered Suggestions

  1. +1.06% via ...edColumnSyntax.scala#38...49
  2. +0.89% via ...cutor/Database.scala#157...166
  3. +0.80% via ...atementBuilder.scala#47...55
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

p14n commented 8 years ago

I'm using executeUpdate in this case because generated keys aren't returned for executeBatch (in jt400 implementation). I haven't updated the others to use executeBatch. For discussion.

p14n commented 8 years ago

@brendanator @DavidGregory084 Happy to merge?

DavidGregory084 commented 8 years ago

:+1: here

brendanator commented 8 years ago

:+1: