search

jhc-systems / sqlest

Write SQL in Scala
https://jhc-systems.github.io/sqlest/latest/api/
Apache License 2.0
30 stars 17 forks source link

Fix DB2 OFFSET implementation #96

Closed CHAZOTA closed 5 years ago

CHAZOTA commented 5 years ago

There's an issue with the current DB2 implementation of OFFSET. Fix is WIP

codecov-io commented 5 years ago

Codecov Report

Merging #96 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   82.88%   82.93%   +0.04%     
==========================================
  Files          46       46              
  Lines        1198     1201       +3     
  Branches       98       96       -2     
==========================================
+ Hits          993      996       +3     
  Misses        205      205
Impacted Files Coverage Δ
...rc/main/scala/sqlest/sql/DB2StatementBuilder.scala 72.5% <100%> (+2.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb193bd...d41f730. Read the comment docs.

CHAZOTA commented 5 years ago

Have you published locally and checked that your local SNAPSHOT can run bridgeUp/serverUp tasks successfully?

Yeah - serverUp & bridgeUp ran without error. I also tested a couple of services that use offset

RobertEMackay commented 5 years ago

Have you published locally and checked that your local SNAPSHOT can run bridgeUp/serverUp tasks successfully?

I've checked it too.