search

jhchee18 / pe

0 stars 0 forks source link

"/" not allowed in name #3

Open jhchee18 opened 1 year ago

jhchee18 commented 1 year ago

User with name contains "/" might not be able to add their name, which hinders the user. Error message shows "can contain hypens...", did not say should not contain "/"

Input: addbuyer -n Mathan s/o Deva -ph 87321237 -e tim@gmail.com -a S648234 -pr HIGH

image.png

nus-pe-script commented 1 year ago

Team's Response

Can replace slash with dash if required Not in scope as we have already allowed for other special characters; difficult to be exhaustive

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Notes from PE guidelines say that:

image.png

when users are trying to search for the legal name of the buyer, they could search for "s/o" in this case.

However, the suggestion to replace "/" with "-" won't match the desired buyer.

image.png

Command: findbuyers s/o

image.png

which caused the find command to lose its purpose.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Users fail to add buyers with "/" in their names, which will also the operation of find .It is a flaw that causes occasional inconvenience to some users but they can continue to use the product.

Suggestion: severity.Medium