jhchee18 / pe

0 stars 0 forks source link

priority not captured #4

Open jhchee18 opened 1 year ago

jhchee18 commented 1 year ago

when 2 -pr instances are input, no error message is shown, the buyer gets added

input: addbuyer -n Mathan so Deva -ph 87321237 -e tim@gmail.com -a 11, Kallang way 3, #03 -pr 14 -pr LOW

image.png

nus-se-bot commented 1 year ago

Team's Response

Similar issue where if multiple of the same flags are provided, only the last one will be accepted, but not mentioned in User Guide

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

addbuyer: Duplicate flags are allowed

Description: User can enter multiple flags of "-n", "-p", etc, only the last value is used

To reproduce: Enter addbuyer -n aa -n bb -ph 10000000 -e 1@email.com -a Mars
or addbuyer -n aa -n bc -ph 100000021 -ph 10000032 -e 2@email.com -a Mars

Expected: Disallow the command and warn the user there are duplicated flags

Actual: The person is added with the last flag as name/phone

image.png

image.png


[original: nus-cs2103-AY2223S1/pe-interim#5768] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This behaviour is as expected, and we added a disclaimer to the User Guide which somehow got deleted somewhere along the way.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]