search

jhead / node-svmq

Native System V message queues in Node.js
MIT License
19 stars 10 forks source link

Fix deprecated Int32Value for node12 #5

Closed KimNyholm closed 5 years ago

KimNyholm commented 5 years ago

See issue Int32Value() deprecated with node 12

jhead commented 5 years ago

Thanks for the PR! @KimNyholm

Small nitpick, could we use the shorter syntax described here? https://github.com/bcoin-org/bcrypto/issues/7#issuecomment-498964097

Nan::To<int32_t>(info[0]).FromJust()
KimNyholm commented 5 years ago

Something like this?

jhead commented 5 years ago

Looks good to me, thanks! If there's no rush to release it, I'd like to fix the other deprecated calls and add a test first.

jhead commented 5 years ago

v1.0.7 published, I'll get to the other stuff later.