Closed KimNyholm closed 5 years ago
Thanks for the PR! @KimNyholm
Small nitpick, could we use the shorter syntax described here? https://github.com/bcoin-org/bcrypto/issues/7#issuecomment-498964097
Nan::To<int32_t>(info[0]).FromJust()
Something like this?
Looks good to me, thanks! If there's no rush to release it, I'd like to fix the other deprecated calls and add a test first.
v1.0.7 published, I'll get to the other stuff later.
See issue Int32Value() deprecated with node 12