search

jhedstrom / DrupalDriver

A collection of drivers for controlling Drupal.
GNU General Public License v2.0
64 stars 95 forks source link

Allow Symfony 4 as dependency #222

Closed Berdir closed 4 years ago

Berdir commented 4 years ago

Requiring ~4.4 as that's what Drupal 9 requires anyway.

Berdir commented 4 years ago

PHP 7.4 fails seem unrelated to this, phpunit and other dependencies will need to be updated to supported versions to fix that.

jhedstrom commented 4 years ago

Hmm, what should we do regarding the php 7.4 failure? I'm assuming this is still being sorted out in Drupal itself?

Berdir commented 4 years ago

Latest drupal 8 dev should be 7.4 compatible, that doesn't seem to be the problem here but your own dependencies as far as I see.

You still require PHPUnit 4, Drupal 8 uses 6/7 while Drupal 9 uses Phpunit 8. And some other dependencies that might need to be updated too.

I'm not sure why 7.4 is even currently tested, this can't work right now in HEAD either?

Berdir commented 4 years ago

Having a look at how much work it is to update those dependencies and if things break, but to me it would make more sense to do that in a separate PR :)