Closed AlexSkrypnyk closed 1 year ago
@pfrenssen Thank you for reviewing this. Agree with all comments. I will address them shortly. Thanks
@pfrenssen I have addressed all the comments. Could you please review again. Thank you
re: testing on previous PHP versions
I think it is these lines that are causing those to not work:
"drupal/core-composer-scaffold": "^10@beta",
"drupal/core-recommended": "^10@beta",
They can probably either be removed, or switched to allow the older versions of Drupal as in the require
section:
"drupal/core-utility": "^8.4 || ^9 || ^10.@beta"
@jhedstrom could you please advise what do they have to be switched to?
I think they just need to allow 8.4 and 9 like we do for the core-utility
:
"drupal/core-composer-scaffold": "^8.4 || ^9 || ^10@beta",
"drupal/core-recommended": "^8.4 || ^9 || ^10@beta",
(we could probably drop 8.x for now too, and then drop 9 when it is eol.)
thank you @jhedstrom I've updated the configs, but ran out of OSS credits on Travis CI (can we switch to Circle or GH actions?). Not sure how to test this without those credits. Probably have to wait till Nov 1.
@AlexSkrypnyk I've opened #254 to track that. It should be a relatively small effort.
Also, there's https://github.com/jhedstrom/DrupalDriver/issues/249 that might be relevant to the version changes happening here for core libraries.
@claudiu-cristea @jhedstrom
I've updated this PR with the latest changes from master
and updated CI to include D10. Could you please review. Thank you
Thanks!
@jhedstrom This PR introduced a conflict with older Drupal versions which seems like something that shouldn't happen in a patch
release (but should be a major version release instead). This prevents upgrading in some instances.
See https://github.com/goalgorilla/open_social_dev/pull/51 for the conflict message that this causes.
Symfony\Process
in Drush Driver (copied from https://github.com/jhedstrom/DrupalDriver/pull/251 - sorry, had to keep it in this branch for downstream projects)Please note that Rector and Drupal check are only scanning Drupal 8 driver.