search

jhedstrom / DrupalDriver

A collection of drivers for controlling Drupal.
GNU General Public License v2.0
64 stars 95 forks source link

Drupal 10 compatibility broke taxonomy term creation in patch version #259

Closed Kingdutch closed 1 year ago

Kingdutch commented 1 year ago

https://github.com/jhedstrom/DrupalDriver/pull/250/commits/8177f645a229f40ba88b4c20daffe1a124c54445 changed how taxonomy term creation worked in 2.2.1 but this broke the functionality.

parent may be empty if multiple taxonomies are created in a single Given block as pointed out in https://github.com/jhedstrom/DrupalDriver/pull/257

Additionally id is not the right base field for the query but it should be name.

Finally the entityQuery does not return loaded entities but returns IDs so calling ->id() on it will break as well.

Kingdutch commented 1 year ago

Hosting static patch so it can be easily used to fix our CI DrupalDriver-pr-260.patch

bkosborne commented 1 year ago

Came across this as well. Thanks for posting a patch!