jheling / freeathome

Free@Home component for Home Assistant
103 stars 37 forks source link

Temperature correction via entity service #91

Closed steffenaxer closed 3 years ago

steffenaxer commented 3 years ago

This commit allows us to set the temperature correction via an entity service, similar to the cover device. You can test service by the help of the developer tools --> freeathome.thermostat_temperature_correction --> select your climate device

Tho85 commented 3 years ago

Looks good :+1:

In the long run I think it would be better to have two generic services: freeathome.set_datapoint and freeathome.set_parameter. There are so many possible parameters and datapoints that we can't cover all of them with custom services. The services could be called like this:

service: freeathome.set_datapoint
data:
  entity_id: cover.kitchen
  datapoint: force_position
  value: open

or

service. freeathome.set_parameter
data:
  entity_id: climate.kitchen
  parameter: temperature_correction
  value: 0.5

However, this is still too far away, so let's merge this PR :rocket:

steffenaxer commented 3 years ago

I might have one more question we should discuss. Will give more infos this evening.