jhelovuo / RustDDS

Rust implementation of Data Distribution Service
Apache License 2.0
330 stars 66 forks source link

Fix overly strict lifetime requirements for deserialization helpers #291

Closed phil-opp closed 1 year ago

phil-opp commented 1 year ago

And other improvements:

phil-opp commented 1 year ago

Happy to split this up into separate PRs if you prefer.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.09 :warning:

Comparison is base (3b4f224) 70.44% compared to head (48890c5) 70.36%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #291 +/- ## ========================================== - Coverage 70.44% 70.36% -0.09% ========================================== Files 111 111 Lines 20278 20261 -17 ========================================== - Hits 14285 14256 -29 - Misses 5993 6005 +12 ``` | [Impacted Files](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/dds/key.rs](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2Rkcy9rZXkucnM=) | `64.47% <ø> (ø)` | | | [src/dds/pubsub.rs](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2Rkcy9wdWJzdWIucnM=) | `85.95% <ø> (-0.10%)` | :arrow_down: | | [src/dds/with\_key/datareader.rs](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2Rkcy93aXRoX2tleS9kYXRhcmVhZGVyLnJz) | `84.41% <ø> (ø)` | | | [src/dds/with\_key/datasample.rs](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2Rkcy93aXRoX2tleS9kYXRhc2FtcGxlLnJz) | `40.35% <0.00%> (+2.01%)` | :arrow_up: | | [src/dds/with\_key/datasample\_cache.rs](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2Rkcy93aXRoX2tleS9kYXRhc2FtcGxlX2NhY2hlLnJz) | `81.34% <ø> (ø)` | | | [src/dds/with\_key/datawriter.rs](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2Rkcy93aXRoX2tleS9kYXRhd3JpdGVyLnJz) | `60.18% <ø> (ø)` | | | [src/dds/with\_key/simpledatareader.rs](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2Rkcy93aXRoX2tleS9zaW1wbGVkYXRhcmVhZGVyLnJz) | `54.57% <ø> (ø)` | | | [src/lib.rs](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xpYi5ycw==) | `100.00% <ø> (ø)` | | | [src/ros2/ros\_node.rs](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3JvczIvcm9zX25vZGUucnM=) | `50.27% <ø> (+0.27%)` | :arrow_up: | | [src/test/test\_properties.rs](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Rlc3QvdGVzdF9wcm9wZXJ0aWVzLnJz) | `100.00% <ø> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/jhelovuo/RustDDS/pull/291/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jhelovuo commented 1 year ago

Thanks. This is much appreciated. It seems that specifying trait bounds on an associated type works now better than it did ~3 years ago.

ohuopio commented 1 year ago

Yes, these seem to be good improvements. Thank you!