search

jhelovuo / RustDDS

Rust implementation of Data Distribution Service
Apache License 2.0
331 stars 67 forks source link

Fixed Windows UDP unicast only working on a single network interface #345

Closed Guacimo closed 3 months ago

Guacimo commented 4 months ago

Removed the logic that tries to bind all interfaces to a UDP socket on Windows. I do not understand why this would be necessary. The result seems to be that the socket binds to the earliest listed interface it can bind to and fails all other interfaces. This means that RustDDS fails to send unicast UDP messages to any devices that are not available to that first interface. Binding to "0.0.0.0" works on Windows so I removed the conditional compilation syntax. The fact that this code was present leads me to believe that this fixed something earlier, right now I cannot determine what this was.

codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.27%. Comparing base (28ed26f) to head (1fee674). Report is 143 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #345 +/- ## ========================================== - Coverage 73.53% 71.27% -2.27% ========================================== Files 94 93 -1 Lines 19845 18504 -1341 ========================================== - Hits 14594 13189 -1405 - Misses 5251 5315 +64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jhelovuo commented 3 months ago

Thank you for the contribution.