search

jhelvy / logitr

Fast estimation of multinomial (MNL) and mixed logit (MXL) models in R with "Preference" space or "Willingness-to-pay" (WTP) space utility parameterizations in R
https://jhelvy.github.io/logitr/
Other
43 stars 15 forks source link

Compatibility with gtsummary v2.0 #56

Closed ddsjoberg closed 4 months ago

ddsjoberg commented 4 months ago

Dear @jhelvy ,

I am preparing the submission of gtsummary v2.0 to CRAN, and I wanted to alert you to a change you may need to incorporate in logitr.

The gtsummary package utilizes the broom.helpers package to prepare regression model results. In the updated version of the package, the broom.helpers package has moved from Imports to Suggests. As a result, you may also need to add broom.helpers to the logitr Suggests field so the package is available when your vignettes are created.

Apologies for any inconvenience, Daniel

jhelvy commented 4 months ago

Thanks for taking the time to make this check and make the adjustment for me! I'll merge the PR.

jhelvy commented 4 months ago

Btw, will this cause issues on CRAN? If so I can release a small update to CRAN.

ddsjoberg commented 4 months ago

Btw, will this cause issues on CRAN? If so I can release a small update to CRAN.

I think you'll get an email from CRAN requiring an update once they get around to making the checks. FYI the CRAN holiday begins Aug 1: not sure what they're schedule is for the checks, however.

jhelvy commented 4 months ago

Already got an automated email from CRAN! Gonna push this version to get this taken care of.

jhelvy commented 4 months ago

Okay v1.1.2 is now up on CRAN with this fix, hopefully that solves everything.