search

jhelvy / splitKbCompare

An interactive tool for comparing layouts of different split mechanical keyboards
https://jhelvy.github.io/splitKbCompare/
MIT License
264 stars 29 forks source link

add switchtype and switchspacing information to keyboard.csv #56

Closed weteor closed 3 years ago

weteor commented 3 years ago

This should help resolving issue #55 .

I've broadened the scope a bit, since I think the requested filters need also information on the switch spacing. I've added the following columns to keyboard.csv:

mxCompatible - board supports mx-style switches (was cherry in your suggestion) chocV1 - board supports Kailh Choc V1 (PG1350) switches chocV2 - board supports Kailh Choc V2 (PG1353) switches

mxSpacing - board supports 19x19mm switch spacing for MX and/or Choc V2 chocSpacing - board supports 18x17mm switch spacing for Choc V1

jhelvy commented 3 years ago

Wow, thanks for taking the effort to add the data here. Shouldn't take too much more effort to add those filters in.

One question though is how to set up the filter. Would it be sufficient to just say "Switch support" as a multiple check box and let the user click the switches? I would just have "MX", "Choc V1", and "Choc V2" as the options in that case. That is to say that (I think) the spacing columns can be determined by these three options, is that right?

weteor commented 3 years ago

Switch support as checkboxes sounds good. The spacing cannot be determined by the switchtype though, since most boards are Mx-spaced, but have switch footprints that allow multiple switchtypes, including ChocV1, to be soldered in.

The spacing should be a seperate filter.