jhelvy / splitKbCompare

An interactive tool for comparing layouts of different split mechanical keyboards
https://jhelvy.github.io/splitKbCompare/
MIT License
270 stars 30 forks source link

Add Ability For Multi-page PDF -- 1 Keyboard Per Page #64

Closed JZL closed 2 years ago

JZL commented 3 years ago

Hi,

I've been enjoying using this to decide which keyboard to build, thanks for building it :-)

The one thing which was missing for me was the ability to print a set of keyboards individually so I could 'try' them out and decide. Sort of like #39. These all get towards that goal (although maybe other small tweaks which might be useful).

The UI tweaks are shown in [1], I added a "Select All Filtered" button (5d81900) to make it easier to select a lot of keyboards at once (which also uncovered an index overflow in the palette selection) and two new "Separate Page" buttons which exports one keyboard per page (25f54bc). I could also imagine keeping only the two export pdf buttons and converting them into a drop down for "Separate" or "All Together"

Finally, I'm happy to help with this but similar to the hotlinking in #54, I thought this led to some possible related features (3e45b08) where a mega pdf is generated with one page per keyboard for people who wanted to compare quickly/print a selection. Also a hot link to a pdf for each keyboard might make it even easier for keyboard creators to link to an easy printing page like the kyria

Per the implenetation:

[1] image

jhelvy commented 2 years ago

Wow, these are some really nice additions! I really appreciate the time you took to implement them. This is a side project that I have less and less time to maintain, so some fresh edits are welcome.

Some quick reactions:

Finally, magick is relatively slow, but I haven't found a better option. Here are some other thoughts I had on it:

If you want to play with any of these ideas in this PR, let me know, otherwise I'll go ahead and merge this one and we can consider these other modifications in a different one.

jhelvy commented 2 years ago

I went ahead and merged this PR as it was in good shape. My comments here I've now put in the todo.txt file.