search

jhelvy / splitKbCompare

An interactive tool for comparing layouts of different split mechanical keyboards
https://jhelvy.github.io/splitKbCompare/
MIT License
270 stars 30 forks source link

Open source filter and uiElements.R #80

Closed undefined-landmark closed 2 years ago

undefined-landmark commented 2 years ago

Hi,

Some small changes and one optional larger change.

Small changes:

Larger change Whilst trying out shinydashboard I was scrolling though the file a lot. All the filter buttons made it somewhat difficult to get an overview of the structure and all the nested functions. Moving all the filter buttons to a separate file makes it a bit easier to oversee what happens where in ui.R.

Let me know what you think about the changes!

netlify[bot] commented 2 years ago

✔️ Deploy Preview for splitkbcompare ready!

🔨 Explore the source changes: 5a1b5ce6a7b72b304707036a72b621d940e28ae8

🔍 Inspect the deploy log: https://app.netlify.com/sites/splitkbcompare/deploys/61cc9fcd28a1da00070d04ac

😎 Browse the preview: https://deploy-preview-80--splitkbcompare.netlify.app

jhelvy commented 2 years ago

All looks good to me! I think modularizing the UI components is a step in the right direction - it will certainly make things easier when working with other UIs like shinydashboard.