search

jhelvy / splitKbCompare

An interactive tool for comparing layouts of different split mechanical keyboards
https://jhelvy.github.io/splitKbCompare/
MIT License
270 stars 30 forks source link

Kyria is not Open Source #86

Closed hoijui closed 2 years ago

hoijui commented 2 years ago

The kyria has a repo with an open source license, but that repo only contains files for cases, not for the PCB or anything else. I wanted to change that with a PR, but I saw no OpenSource column in keyboards.csv. How could I set it as non OS?

jhelvy commented 2 years ago

I don't keep track of whether a board is open source or not on this app. I just include links to the source (if available) and links to a store to buy it at (if available). I certainly appreciate open source boards, but I also understand if folks want to keep their design proprietary, especially if they sell it.

hoijui commented 2 years ago

well.. there is a filter named "OpenSource", so... is that ill-named then?

hoijui commented 2 years ago

2022-06-09-20-59-05-area

jhelvy commented 2 years ago

Huh...must have been added more recently. Others have contributed to the project more recently with a few suggested UI changes, that's one I didn't catch. I'll go find where it's pulling that from and will swap Kyria to the closed source list.

jhelvy commented 2 years ago

Okay I just updated the app. Someone had added the "open source" menu item based on whether there was a url for the "source". Kyria has a url to a github repo, but the repo doesn't include all the source files. So I just added a new openSource variable in the keyboards.csv file.

hoijui commented 2 years ago

Perfect solution, thank you! :-)