search

jhen0409 / react-chrome-extension-boilerplate

Boilerplate for Chrome Extension React.js project
MIT License
2.14k stars 388 forks source link

Unsupported manifest property in latest Chrome Canary 49 #20

Open zalmoxisus opened 8 years ago

zalmoxisus commented 8 years ago

The icons.scalable property is not supported in latest Canary, and as a result the extension fail to install. I do not see any alternatives as to remove it.

BTW, @jhen0409, what do you think if we'll test (on Travis or AppVeyor) in Canary as well, so it would be possible to avoid some problems in new Chrome version before it would be released? Not sure though if it would be possible.

jhen0409 commented 8 years ago

Hey @zalmoxisus, thanks report, I will fix it. :D

Also, test Canary on Travis/AppVeyor is good idea, but It seems none provided Linux version?

zalmoxisus commented 8 years ago

I didn't know Canary isn't available for Linux, but hopefully we have Windows on AppVeyor, and there's no reason to test it also on Travis. I guess we have to install Canary using Chocolatey, Web Platform Installer (Web PI) or PowerShell, and then add an additional test with new Chrome path.

jhen0409 commented 8 years ago

@zalmoxisus do you can find offline installer of official? or we can use ChromeSetup.exe to install chrome directly by msiexec?

zalmoxisus commented 8 years ago

I think ChromeSetup.exe will not work, I found an offline installer (also from here, which should work. But I'm not sure AppVeyor offers a way to install it only once, otherwise the tests would be too slow to download a 45 MB file and install chrome every time.