search

jhen0409 / react-chrome-extension-boilerplate

Boilerplate for Chrome Extension React.js project
MIT License
2.14k stars 388 forks source link

Submission Rejected - Contains minified or obfuscated code #96

Open cihadturhan opened 6 years ago

cihadturhan commented 6 years ago

Hello,

Today I submitted my extension to Chrome Web Store. But they respond me with the following:

Per our policies, where possible, make as much of your code visible in the
package as you can. If some of your app's logic is hidden and it appears to
be suspicious, we may remove it. During the course of a review, your item
was found to be suspicious and has one or more file(s) that contain
minified or obfuscated code which is not human readable.

Do you submit with dev or dist folder? It means anyone uses dist folder will have problems as it has obfuscated code. Please let me know if you used obfuscated code.

Thanks

zabka229 commented 6 years ago

Did you solved the problem?

cihadturhan commented 6 years ago

I solved it by disabling uglfy feature on webpack dist config. After that, they accepted the extension. It’s very strange that there are plenty of extensions with minified code. I’m on mobile so pardon for any typos.

zabka229 commented 6 years ago

Did your bundle size increased a lot? :)

cihadturhan commented 6 years ago

Hey @zabka229 I just saw your comment. It definitely increases ~300kb or more depending on your package.json. But that’s not a problem as chrome extension comes bundled and doesn’t load the file from any server.

piavgh commented 4 years ago

@cihadturhan : Hi, your post is from 2018. Do you have any problem with this issue since then?

I plan to create my extension, and I'm considering some boilerplates (React). Not sure if using React boilerplate causes me any trouble in the future, because I don't want to spend time building an extension and get rejected when I want to submit it to the store.

Another question: I see that this repository is not active since 2018. Are you using any newer (and better) boilerplate for chrome extension development? If yes, please suggest it to me.

Thank you.

cihadturhan commented 4 years ago

@piavgh I had no problems since then. To be honest, I didn't add new features for a while. See the extension: https://chrome.google.com/webstore/detail/clipboard-paste-anywhere/pbmkobomelmhlgfbfjohpblialcopjco?hl=en-US