search

jhennies / CebraEM

MIT License
5 stars 2 forks source link

Click commandline interfaces #54

Closed dokempf closed 9 months ago

dokempf commented 11 months ago

Rewrites CLIs to use the click library which will allow us to automatically generate a GUI using clickqt (an updated release of clickqt will come in the next days).

The new CLIs deviate slightly from the previous for both technical and consistency reasons. We have not discussed how hard this would be on you @jhennies and your users. If it matters a lot because of many existing scripts etc., I can try to further increase the compatibility (Example: I have not yet added short form options like -t for --target).

This fixes #48.

dokempf commented 11 months ago

By the way, if we want to be a bit more conservative with these breaking changes, we could change the target branch for my changes to a new branch like ssc and then merge that to main when all current issues are implemented.

jhennies commented 11 months ago

The new CLIs deviate slightly from the previous for both technical and consistency reasons. We have not discussed how hard this would be on you @jhennies and your users. If it matters a lot because of many existing scripts etc., I can try to further increase the compatibility (Example: I have not yet added short form options like -t for --target).

I think in particular the --target option is very frequently used such that it would make life easier if the short -t was kept. On the other hand, since it is in practice used every time, we could also simply make it mandatory... Thinking about it, I would actually prefer that :)

jhennies commented 11 months ago

By the way, if we want to be a bit more conservative with these breaking changes, we could change the target branch for my changes to a new branch like ssc and then merge that to main when all current issues are implemented.

I agree, let's be conservative, considering we are currently actively using the software. I'll create the ssc branch