search

jhermsmeier / node-dkim

DomainKeys Identified Mail
MIT License
10 stars 11 forks source link

Add MS Exchange verify test #10

Closed SmallhillCZ closed 5 years ago

SmallhillCZ commented 5 years ago

Adding tests for #9. The issue is actually connected to MS Exchange rather than Outlook as the signatures are added by the Exchange server.

SmallhillCZ commented 5 years ago

I had some trouble with the detection of header boundary in the CI tests as my git probably converted the line endings (the test went OK locally), so I added the .gitattributes file to preserve the raw messages.

jhermsmeier commented 5 years ago

as my git probably converted the line endings (the test went OK locally), so I added the .gitattributes file

You might want to adjust your core.autocrlf and core.safecrlf settings in your git config to prevent it from automatically mangling line endings on checkout etc.

That said, I would highly prefer if you could remove the .gitattributes from this PR, as setting text files to binary can mess with the diffing