search

jhermsmeier / node-dkim

DomainKeys Identified Mail
MIT License
10 stars 11 forks source link

(fix) relaxed header canonicalization & improve tests #13

Closed nionis closed 4 years ago

nionis commented 4 years ago

fixes https://github.com/jhermsmeier/node-dkim/issues/12

I decided to use my real emails because it would have been very hard to make test emails, especially for icloud. I have looked into it and it should be okay.

jhermsmeier commented 4 years ago

Awesome, thank you! One thing though; can you please revert the code-style changes? It makes the diff very noisy, and thus harder to review. If you'd like to change the code-style, please do so in a separate PR :)

nionis commented 4 years ago

@jhermsmeier right, my bad there

nionis commented 4 years ago

@jhermsmeier force pushed and fixed the commit

jhermsmeier commented 4 years ago

Thanks again!

jhermsmeier commented 4 years ago

Published in dkim@0.7.1