doesn't support rsa 2048 keys?

niftylettuce commented 6 years ago

doesn't seem to support long multi-line keys

e.g.

"v=DKIM1; k=rsa; p="
"MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA72KY0zgC+o140+5D6SuS"
"5+2I5Q6dLgZnLGCs0vlHcHvINutUlM4gKDuQ17ENaphKMosmzaA1lCzlZyZdPHN8"
"dLe8VOjQgkcxFpkB9r3SciE70BmkpRDbBqeU4CRPqYtv+g+VtBEvuEbV0j057xpJ"
"pRTHjBLEHbe3+2dzTk5T8vkGKX6nftjSzmpd1JkPxHDR4lykxemp6dC7CSyf+5Jo"
"0Tdp1YgItRJySk663DqJQ67yPpWqRhhljIkhMVeB5EHYPdThihWOi3Gj9BG6/oRM"
"XxeKCdipYXzD3JKJucD0GTqo53Ym2yCAAjWdxD25y/Ti3fkQSu9PxtUcdZ00kjXJ"
"owIDAQAB"

gets read as

records [ [ '0Tdp1YgItRJySk663DqJQ67yPpWqRhhljIkhMVeB5EHYPdThihWOi3Gj9BG6/oRM' ],
  [ '5+2I5Q6dLgZnLGCs0vlHcHvINutUlM4gKDuQ17ENaphKMosmzaA1lCzlZyZdPHN8' ],
  [ 'MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA72KY0zgC+o140+5D6SuS' ],
  [ 'XxeKCdipYXzD3JKJucD0GTqo53Ym2yCAAjWdxD25y/Ti3fkQSu9PxtUcdZ00kjXJ' ],
  [ 'dLe8VOjQgkcxFpkB9r3SciE70BmkpRDbBqeU4CRPqYtv+g+VtBEvuEbV0j057xpJ' ],
  [ 'owIDAQAB' ],
  [ 'pRTHjBLEHbe3+2dzTk5T8vkGKX6nftjSzmpd1JkPxHDR4lykxemp6dC7CSyf+5Jo' ],
  [ 'v=DKIM1; k=rsa; p=' ] ]

and doesn't get concatenated/joined so key.key is empty and toString() can't be called

fuse-mars commented 6 years ago

@niftylettuce i think it would help if you can create a Failing test for this issue :)

niftylettuce commented 5 years ago

See https://lxadm.com/Generating_DKIM_key_with_openssl#Generating_2048_bit_DKIM_key. We should add 2048 bit DKIM key support to this.

jhermsmeier commented 5 years ago

Yup, @niftylettuce I'll spend some time on this soon

jhermsmeier commented 5 years ago

Fixed in 643c4fe27f2fa007fd33eeaff7b8235db3830d37 and published as dkim@0.4.2

niftylettuce commented 5 years ago

thank you again for this @jhermsmeier - I've now implemented your package in https://forwardemail.net

jhermsmeier / node-dkim

doesn't support rsa 2048 keys? #2