search

jhermsmeier / node-dkim

DomainKeys Identified Mail
MIT License
10 stars 11 forks source link

we should remove X-Google-DKIM-Signature, it's not to RFC standards #8

Closed niftylettuce closed 5 years ago

jhermsmeier commented 5 years ago

Other than that it's not defined in an RFC, is it causing any issues, or why would you argue for it to be removed?

niftylettuce commented 5 years ago

It's not a real DKIM signature, and no email client parses it as far as I know, anything with X- as you know is just extra metadata.

jhermsmeier commented 5 years ago

It's not a real DKIM signature

Last time I checked, it was. What else would it be? If it doesn't verify, that's another issue. If you have a real sample message, and a test case to prove it, I'm happy to look at it, and remove the X-Google-DKIM matching, if it checks out.

and no email client parses it as far as I know

And that's an argument? Most email clients don't even check / verify DKIM signatures. Sorry, but that's just no standard I'm going to measure against.