search

jherr / create-mf-app

CLI app to create Module Federation applications
MIT License
730 stars 84 forks source link

Remove NODE_ENV=production and NODE_ENV=development from rspack scripts #71

Closed CosmeValera closed 1 month ago

CosmeValera commented 4 months ago

🧠 WHAT

Remove NODE_ENV=production and NODE_ENV=development from rspack scripts. So it works out of the box

📷 IMAGE

image image

https://github.com/jherr/create-mf-app/issues/70

zmzlois commented 2 months ago

Unsure about other frameworks, React do additional checks for NODE_ENV=development and when it sets to NODE_ENV=production it will optimise performance.

CosmeValera commented 1 month ago

@zmzlois you can try for yourself but with how it was it was not working. I guess additional config was missing