search

jherr / jmusic

Javascript Music project
19 stars 12 forks source link

Project setup and definitions #10

Open pazel-io opened 3 years ago

pazel-io commented 3 years ago

Hi @jherr ,

I had a look at the project, and I have some suggestions. 
I am not a guitar player, so I need to know more about the concept and the domain. I can see you are already using DSL in the component naming. It would be nice to add a bit more documentation or even another video to define the concept.

About the UI/UX, it would be good to have some low-fidelity designs to give contributors a bit of idea of how to advance the UI/UX and overall guidelines.



You probably also need a list of features you wish for the contributors to work on. If I want to start today, I do not know really what needs to be done. Having a list, we can track the feature completion and tasks that are included in each.

Things like code conventions are nice to be shared as well. If conventions are based on what React community does, you can perhaps share some links on them.

chefinDan commented 3 years ago

Who exactly is the customer? A lot of these decisions require having a decent understanding of business value. I'm more inclined to say, let people create branches and go crazy with features. But maybe this is more serious than that? For now I'm optimistically observing.

jherr commented 3 years ago

Great points. Hopefully covered to some degree with https://github.com/jherr/jmusic/pull/13