Open Fhrozen opened 5 years ago
Hi Fhrozen, thanks for the suggestion.
Lifting the requirement to add the lib would indeed be a nice improvement.
I won't be able to test it until next week and will comment once I was able to do so.
Do you think there is a way to achieve the same without breaking the pip install ...
functionality?
I tested with both python setup
and pip install
and found no problem only need to remove from the previous code the lines:
include_package_data=True,
package_data={'chainer_ctc': [os.path.realpath('{}/{}'.format(warp_ctc_libpath, warp_ctc_libname))]},
the setup.py
will link the warp_ctc
to the one located at '{}/{}'.format(warp_ctc_libpath, warp_ctc_libname)
I was trying to move link to that would be storage at site-packages/ but could not achieved. Still missing a flag maybe in the setup, but I do not have time to test now.
For espnet the requirement to add libwarpctc.so to LD is quite troublesome. I just finished some test after adding some lines and didnot find any trouble:
this will required to install the package using:
python setup.py install
and with no longer required to add the lib to LD @sw005320 , @jheymann85Let me know if is fine or not.