search

jhfrench / bootstrap-tree

JavaScript and LESS/CSS for creating Bootstrap-themed trees (to display hierarchical data).
202 stars 76 forks source link

Design suggestion #3

Closed kumarharsh closed 11 years ago

kumarharsh commented 11 years ago

Hi Jeromy, I would like to suggest a modification to the styling, as I had pointed out in my comment here.

  1. Instead of the child elements absolutely losing their colour on hovering the parent, It would be better (strictly my opinion) to highlight the paths of the child nodes which will be closed.
  2. Or highlight the borders of the nodes to be closed instead of the whole background.

It seemed a bit buggy to me initially when I first saw it all those months ago, but I let it pass. I noticed your repo today, and thought I'll have a look. The tree is absolutely fantastic, except that one niggle which I just can't shake, so I thought I'd rather raise this issue for you to consider.

Thanks for your patience. -- khs

jhfrench commented 11 years ago

I like that there's a visual indication of what will be collapsed when the user hover's over the parent item. Your idea of changing the color on the border is a good one. There might be a way to make this slicker...would you care to code an enhancement and submit a pull request?

kumarharsh commented 11 years ago

I'd surely like to do that... :)

kumarharsh commented 11 years ago

@jhfrench kindly take a look at the changes, (i've also added a small readme for setting up the project)

jhfrench commented 11 years ago

@kumarharsh sorry for the delay dude, I'll check it out (and learn how to accept pull requests at the same time...)

kumarharsh commented 11 years ago

Thanks a lot... :)