search

jhickner / smtp-mail

Making it easy to send SMTP email from Haskell
BSD 3-Clause "New" or "Revised" License
75 stars 32 forks source link

add parameter to connectSMTP' to specify hostname #17

Closed mwotton closed 7 years ago

mwotton commented 8 years ago

This is a bit of a strawman and it could quite possibly be done better: still, the essence is that I need to specify the hostname of the client sending it, or I get rejected by mail servers for not having an accurate RDNS. getHostname isn't enough, as many domains point to the box I'm using, and I think it's not safe in general to assume a machine has only one.

parsonsmatt commented 7 years ago

Changing the type of a publicly exposed function is a breaking change. I can merge as-is and bump the major version, or we can modify the PR to not change the existing interface and instead add a separate function for this.

mwotton commented 7 years ago

hi @parsonsmatt! I'm happy with either, but don't have the time to redo the patch rn.

parsonsmatt commented 7 years ago

:+1: I'll merge your work and provide the alternate function, that way we won't have to do a breaking change.

mwotton commented 7 years ago

thanks mate :)

On Wed, Dec 7, 2016 at 2:45 PM Matt Parsons notifications@github.com wrote:

👍 I'll merge your work and provide the alternate function, that way we won't have to do a breaking change.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jhickner/smtp-mail/pull/17#issuecomment-265552322, or mute the thread https://github.com/notifications/unsubscribe-auth/AAELgts1qm4wyCzLV-j9S3hmsSfFhAcdks5rFwzlgaJpZM4Ge7Ys .