search

jhiesey / videostream

Play html5 video when from a file-like object
MIT License
243 stars 74 forks source link

MP3 audio seems to be broken #37

Open virtulis opened 7 years ago

virtulis commented 7 years ago

Hi,

I spent some time trying to figure out why a specific video wouldn't play (it plays fine over http, but not so much via webtorrent+videostream). Thought it had something to do with atoms and all, but it looks like videostream just has some problem with the mp3 track (reencoding with -vcodec copy -acodec aac completely solved the issue).

Sorry, I don't currently have an isolated test case so I'm just speculating. But if that's indeed the case then I think it should be documented.

Edit: yep, tried reencoding Sintel audio as mp3 and uploading it to https://instant.io - interestingly, it plays on the upload (seed) page, but not when opening the link in another tab.

Edit 2: ok, it seems to have something to do with the atoms, too.

jhiesey commented 7 years ago

I'm pretty sure videostream doesn't currently work with any audio tracks except aac. Yes, this should be documented! I'll add that soon and leave this bug open until then.

instant.io will fall back to not using videostream, so that probably explains why it's working from the seeder, where the whole file is available. I would expect it would also play (again not using videostream) in a receiving tab once the whole file is downloaded.

jhiesey commented 5 years ago

Well so much for "soon", sorry. I'm finally getting to the issue backlog I promise :)