search

jhiesey / videostream

Play html5 video when from a file-like object
MIT License
247 stars 73 forks source link

Videostream #55

Closed elbrujo1987 closed 4 years ago

elbrujo1987 commented 4 years ago

👍

diegocr commented 4 years ago

What's going on here? :-)

Be aware our fork cannot be merged here as-is, it will break this badly and any npm dependents.

Also, let me point out we don't endorse nor know who is this @elbrujo1987

jhiesey commented 4 years ago

Sorry, I haven't been putting much time into maintaining this module recently. I'll look at it this weekend.

diegocr commented 4 years ago

No worries @jhiesey, we know what that does mean ;-)

What i would personally prefer is this PR closed, given the OP is not involved in any way with the upstream meganz:master

jhiesey commented 4 years ago

@elbrujo1987 I don't think this is appropriate to merge in as it is without more significant discussion.

I'm not opposed to making a new major version based on https://github.com/meganz/videostream I just took a quick look at the code and it looks like it has lots of new good stuff, but no documentation about what was added.

@diegocr it looks like you did most of the work on that; if you're interested in documenting your changes I could add you as a maintainer on my repo. Let me know.

diegocr commented 4 years ago

Thanks @jhiesey i will consider it, our company fork is heavily tied to our underlying web-client codebase, so back-porting it to how yours does work won't be quite straight forward i guess, we may could add different layers to work in a way or another, although that will take time to do as well.