search

jhilden / jquery-ui-sass-rails

jQuery UI stylesheets packed as Sass files for the Rails 3.1+ asset pipeline
Other
45 stars 28 forks source link

Non-rails specific repository? #8

Open AlJohri opened 10 years ago

AlJohri commented 10 years ago

Do you have any plans for making this repository slightly less rails specific?

You have one of the most active repositories with a jquery-ui css -> scss conversion and your single file of scss variables is extremely useful.

I'm currently attempting to use your repository with with bower as thus:

"jquery": "~1.10.2",
"jquery-ui": "~1.10.3",
"jquery-ui-sass": "git://github.com/jhilden/jquery-ui-sass-rails#master",

and adding these import statements

@import "variables" // custom override for jquery ui theme variables
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.core.css.scss";

@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.accordion.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.autocomplete.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.button.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.datepicker.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.dialog.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.menu.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.progressbar.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.resizable.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.selectable.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.slider.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.spinner.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.tabs.css.scss";
@import "jquery-ui-sass/app/assets/stylesheets/jquery.ui.tooltip.css.scss";

However:

I can't import any files with relative imports such as jquery.ui.all because the relative imports within the directory don't work without the ".css.scss" extension.

I also can't use the "image-path" rails specific function.

It might be a good idea to have a central jquery-ui-sass repository which is git submoduled and your rake tasks to convert the image-path etc. can be run there?

One tangentially similar project is https://github.com/jquery-ui-bootstrap/jquery-ui-bootstrap which converted the base theme to LESS and modified variables and themes etc. to provide a bootstrap compatible theme.

If you're familiar with bootstrap, you might be aware that they now support both SCSS and LESS using a completely automated conversion rake task.

https://github.com/twbs/bootstrap-sass/blob/master/tasks/converter.rb

It might be easy to build a jquery-ui sass bootstrap theme built off of this repository.

jquery, from what I've read, wants to stick to only web standards so this repository can easily become the defacto jquery-ui-sass repository for all web frameworks instead of just rails.

Just some food for thought and I'd love to help!

jhilden commented 10 years ago

Thanks for your input. I would certainly be open to pulling out the core sass files to a bower-friendly repository. However, I have no bower experience, so I wouldn't really know how to go about it.